Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sockets) ref count usockets context free #12326

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cirospaciari
Copy link
Collaborator

@cirospaciari cirospaciari commented Jul 3, 2024

What does this PR do?

Fixes #10832
Fixes #10991
Fixes #10797
Fixes #10772
Fixes #10695
Fixes #10539
Fixes #10436

context is now ref counted, actual free is delayed until next tick

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Existing tests

@cirospaciari cirospaciari marked this pull request as ready for review July 4, 2024 00:44
@Jarred-Sumner
Copy link
Collaborator

image looks like a build issue on linux

@cirospaciari
Copy link
Collaborator Author

image looks like a build issue on linux

Yeah probably already present in main, did not see how my chances could trigger this. I will take a look into it.

@Jarred-Sumner
Copy link
Collaborator

Jarred-Sumner commented Jul 4, 2024

Where are the tests that would previously fail?

Also, this build issue was not only present on main. It is a missing header.

Copy link
Contributor

github-actions bot commented Jul 5, 2024

@cirospaciari, your commit has failing tests :(

💻 1 failing tests Darwin x64

  • test/js/node/tls/node-tls-cert.test.ts 1 failing

🪟💻 3 failing tests Windows x64 baseline

  • test/cli/install/registry/bun-install-registry.test.ts 1 failing
  • test/cli/install/registry/bun-install-windowsshim.test.ts code 1
  • test/js/node/child_process/child_process.test.ts 1 failing

🪟💻 4 failing tests Windows x64

  • test/cli/install/registry/bun-install-registry.test.ts 1 failing
  • test/cli/install/registry/bun-install-windowsshim.test.ts code 1
  • test/integration/next-pages/test/dev-server.test.ts 1 failing
  • test/js/node/child_process/child_process.test.ts 1 failing

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants