Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSX in react-hello-world.node.jsx the same as others #12259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

victor-homyakov
Copy link

What does this PR do?

The benchmark compares SSR of different React fragments

Deno https://github.com/oven-sh/bun/blob/main/bench/react-hello-world/react-hello-world.deno.jsx

  <html>
    <body>
      <h1>Hello World</h1>
      <p>This is an example.</p>
    </body>
  </html>

Bun https://github.com/oven-sh/bun/blob/main/bench/react-hello-world/react-hello-world.jsx

  <html>
    <body>
      <h1>Hello World</h1>
      <p>This is an example.</p>
    </body>
  </html>

Node https://github.com/oven-sh/bun/blob/main/bench/react-hello-world/react-hello-world.node.jsx

  <html>
    <body>
      <h1>Hello World</h1>
    </body>
  </html>

This PR makes JSX in benchmark equal

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

  • I ran my tests locally

@victor-homyakov
Copy link
Author

Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant