Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support promises in profile method in bun:jsc #12165

Merged
merged 3 commits into from
Jul 7, 2024
Merged

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

If you pass profile an async function it will call .then and continue profiling until the function completes

This also lets you pass arguments through

How did you verify your code works?

There is a test but I think it needs an exception test too

Copy link
Contributor

github-actions bot commented Jun 26, 2024

@Jarred-Sumner, your commit has failing tests :(

🪟💻 3 failing tests Windows x64 baseline

  • test/cli/install/registry/bun-install-registry.test.ts 3 failing
  • test/cli/install/registry/bun-install-windowsshim.test.ts code 1
  • test/js/node/child_process/child_process.test.ts 1 failing

🪟💻 3 failing tests Windows x64

  • test/cli/install/registry/bun-install-registry.test.ts 1 failing
  • test/cli/install/registry/bun-install-windowsshim.test.ts code 1
  • test/js/node/child_process/child_process.test.ts 1 failing

View logs

@Jarred-Sumner Jarred-Sumner merged commit 92bd629 into main Jul 7, 2024
50 of 52 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/proifle branch July 7, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants