Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: escape the regexp pattern to support the build metadata section … #124

Merged
merged 2 commits into from
Jul 26, 2023
Merged

fix: escape the regexp pattern to support the build metadata section … #124

merged 2 commits into from
Jul 26, 2023

Conversation

skyf0cker
Copy link

…of version string

Fix issue #122 to have supports for build section of provider version string

@skyf0cker
Copy link
Author

@outsideris Hope for your review

outsideris
outsideris reviewed Jul 26, 2023
View reviewed changes
Copy link
Owner

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right.
I leave a trivial comment.

lib/provider/cli.js Outdated Show resolved Hide resolved
outsideris
outsideris approved these changes Jul 26, 2023
View reviewed changes
Copy link
Owner

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@outsideris
Copy link
Owner

Ignore CI results. It seems not problem by this commit.

@outsideris outsideris merged commit 73cf898 into outsideris:main Jul 26, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsideris outsideris outsideris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skyf0cker @outsideris