Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more accurate getPrevalence() warning for deletions #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TKMarkCheng
Copy link

A response to #81 which raised the issue of the inaccurate and confusing error message in the GetGenomicsData() API:

In getGenomicData(query_url = "prevalence-by-location", pangolin_lineage = pangolin_lineage, :
Mutations should be specified in the format gene:mutation, like "S:E484K". The following mutations are not in the specified format: S:DEL69/70
  1. Improved Grepl Regex which includes the scenario where a deletion mutation is queried.
  2. Improved error message to show the preferred format for deletions. "{gene}:DEL{start codon}/{end codon}"

@TKMarkCheng
Copy link
Author

Hi! Hoping this branch can be tested and merged soon to clear up the confusion that may arise with usage e.g. #81. However, wanted to have on record that insertions - like ins214EPE found in most omicron sequences, are not accessible by outbreak.info, and thus not covered.
@flaneuse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant