Merge pull request #3 from osteel/feature/proper-compatibility-testing

Improved compatibility testing

.github/workflows/ci.yml

@@ -24,15 +24,19 @@ jobs:
     runs-on: ubuntu-latest
 
     strategy:
+      fail-fast: false
       matrix:
         php-version:
           - "7.4"
           - "8.0"
           - "8.1"
+        dependency-versions:
+          - "lowest"
+          - "highest"
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
@@ -41,7 +45,9 @@ jobs:
           coverage: none
 
       - name: Install composer dependencies
-        uses: "ramsey/composer-install@v1"
+        uses: "ramsey/composer-install@v2"
+        with:
+          dependency-versions: ${{ matrix.dependency-versions }}
 
       - name: Run PHPUnit
-        run: vendor/bin/phpunit
+        run: vendor/bin/phpunit

composer.json

@@ -37,7 +37,7 @@
     },
     "require": {
         "php": "^7.4|^8.0",
-        "symfony/console": "^5.0 | ^6.0"
+        "symfony/console": "^5.1|^6.0"
     },
     "require-dev": {
         "squizlabs/php_codesniffer": "^3.6",

src/Services/Converter.php

@@ -99,7 +99,7 @@ private function processHighlight(string $source, string $target, array $constan
         while (! empty($line = $this->readLine($source))) {
             if ($note !== null) {
                 $note .= sprintf("\n%s", $line);
-            } elseif (is_null($note = str_starts_with($line, 'Note: ') ? substr($line, 6) : null)) {
+            } elseif (is_null($note = strpos($line, 'Note: ') === 0 ? substr($line, 6) : null)) {
                 $highlight .= sprintf("\n%s", $line);
             }
         }