🌱 add support for parsing azure devops urls #4178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
requested review from
spencerschrock and
raghavkaul
and removed request for
a team
JamieMagee
force-pushed
the
azure-devops-repo
branch
from
a3cf3e4
to
f17ce4c
Compare
JamieMagee
temporarily deployed
to
integration-test
GitHub Actions
Inactive
JamieMagee
force-pushed
the
azure-devops-repo
branch
from
f17ce4c
to
f2a8e13
Compare
JamieMagee
temporarily deployed
to
integration-test
GitHub Actions
Inactive
JamieMagee
force-pushed
the
azure-devops-repo
branch
from
f2a8e13
to
82c79b3
Compare
JamieMagee
temporarily deployed
to
integration-test
GitHub Actions
Inactive
raghavkaul
reviewed
Jun 20, 2024
| func (r *Repo) parse(input string) error { | ||
| var t string | ||
| c := strings.Split(input, "/") | ||
| if l := len(c); l >= 3 { |
There was a problem hiding this comment.
Does this needs to be after url.Parse? Because we might get https://dev.azure.com/foo?
There was a problem hiding this comment.
Yeah, good point. What would you think about omitting it entirely? url.Parse and the url path length check are more reliable checks.
|
This pull request has been marked stale because it has been open for 10 days with no activity |
JamieMagee
force-pushed
the
azure-devops-repo
branch
from
82c79b3
to
c449f28
Compare
JamieMagee
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: Jamie Magee <[email protected]>
JamieMagee
force-pushed
the
azure-devops-repo
branch
from
c449f28
to
82af7f1
Compare
JamieMagee
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Initial part of feature #4177.
Mainly to see if the overall feature would be accepted and if I am following the contribution guidelines correctly, before I put a lot of work into the rest of the implementation.
What is the current behavior?
N/A
What is the new behavior (if this is a feature change)?**
Azure DevOps URLs can now be parsed
Which issue(s) this PR fixes
Initial part of #4177
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)