🌱 Updates harden-runner egress policy to block from audit
#4163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmuenzenmeyer
requested review from
naveensrinivasan and
raghavkaul
and removed request for
a team
TODO comment says to do this after a few runs, which has occurred. Signed-off-by: Brian Muenzenmeyer <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
Allowlisting is needed. As none of our usages define a list currently.
It didnt always update it, so it fell out of date. And then once it gained the ability to update it, it only updated it if it was correct, which by that point they were out of date so it didn't update the comment. |
|
This pull request has been marked stale because it has been open for 10 days with no activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Flipping the egress policy for harden-runner.
Also updates harden-runner sha comments to accurately match the sha. I know dependabot does this automatically, so unsure how this is out of sync.
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
Policy is set to
audit, which seems to be stable now per runs like https://app.stepsecurity.io/github/ossf/scorecard/actions/runs/9452793546?jobid=26036752635&tab=network-eventsWhat is the new behavior (if this is a feature change)?**
Changed policy to block.
This assumes that the current list is allow-listed. I am still learning harden-runner, but according to the video on the harden-runner README, this can now be flipped.
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
I didn't open an issue first - forgive me. I had a spare moment doing my own scorecard/ harden-runner research and thought this would be useful.
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)