Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CERBERUS RMF Obelix Sensor Config 1 #1037

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

CERBERUS RMF Obelix Sensor Config 1 #1037

wants to merge 5 commits into from

Conversation

acschang
Copy link
Contributor

@acschang acschang commented Nov 5, 2021

Continuation of #1002

mihirk284 and others added 4 commits August 19, 2021 16:53
@mihirk284
Added CERBERUS RMF Obelix Sensor Config 1 config. Mesh to be added.
1190530 
Signed-off-by: Mihir Kulkarni <[email protected]>
@mihirk284
Final Update before PR
cf993b9 
Signed-off-by: Mihir Kulkarni <[email protected]>
@acschang
Matched mass to the stated mass in the specifications file, adjusted …
85dee4f 
…the rotor thrust to hold altitude when provided a zero velocity command, adjusted the minimum range on the ouster sensor to match the datasheet, and added an example rviz file.
@acschang
Updated specifications.md based upon author reply.
1412a35
@acschang acschang mentioned this pull request Nov 5, 2021
Closed
@tiralonghipol
Copy link
Contributor

http://www.m12lenses.com/3-6mm-F1-8-5MP-M12-Mount-CCTV-Lens-p/pt-03618-5mp.htm
@acschang this gets really close (110)
is that ok?

@acschang
Copy link
Contributor Author

acschang commented Nov 8, 2021 •
edited
Loading

http://www.m12lenses.com/3-6mm-F1-8-5MP-M12-Mount-CCTV-Lens-p/pt-03618-5mp.htm @acschang this gets really close (110) is that ok?

Thanks for continuing to look. I'll update the documentation, the provided lens are sufficient for post-competition release. Confirmation of lens FoV being approximately 120 degrees is more important than the specific lens datasheet at this point.

@acschang acschang changed the title Submitted models/cerberus rmf obelix sensor config 1 CERBERUS RMF Obelix Sensor Config 1 Nov 9, 2021
@acschang acschang mentioned this pull request Nov 12, 2021
Closed
tiralonghipol
tiralonghipol approved these changes Nov 20, 2021
View reviewed changes
Copy link
Contributor

@tiralonghipol tiralonghipol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me
@mihirk284 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiralonghipol tiralonghipol tiralonghipol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acschang @tiralonghipol @mihirk284