Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot fix optional metadata Extraction #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sean-k1
Copy link

@sean-k1 sean-k1 commented Dec 1, 2023

resolve #134
without Break we can not go this Block

remainingBytes -= fieldLength;

So InputStream goes wrong position.

@Naros @osheroff
I think we need hotfix?

reproduce this Issue Step

CREATE TABLE `enum_test` (
  `int_column` int NOT NULL AUTO_INCREMENT,
  `smallint_column` int NOT NULL,
  `enum_column` enum('a','b','c') CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL,
  `datetime_column` datetime(6) DEFAULT CURRENT_TIMESTAMP(6),
  PRIMARY KEY (`int_column`)
) ENGINE=InnoDB AUTO_INCREMENT=864 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci


INSERT INTO `enum_test` (`smallint_column`, `enum_column`, `datetime_column`) 
VALUES 
(10, 'a', '2023-12-01 08:30:00'),
(20, 'b', '2023-12-01 09:45:00'),
(15, 'c', '2023-12-01 10:15:00');

alter table enum_test add column `userType` enum('INACTIVE','TERMINATED','ACTIVENONLICENSED','ACTIVE')  NOT NULL;


INSERT INTO `enum_test` (`smallint_column`, `enum_column`, `datetime_column`, `userType`) 
VALUES 
(30, 'a', '2023-12-01 12:00:00', 'INACTIVE'),
(25, 'c', '2023-12-01 13:30:00', 'ACTIVE'),
(35, 'b', '2023-12-01 14:45:00', 'TERMINATED'); <!--- error step----!>

without Break
we can not go this Block

remainingBytes -= fieldLength;
So InputStream Goes wrong
@Naros
Copy link
Collaborator

Naros commented Dec 1, 2023

I definitely agree, maybe Ben can cut a 0.29.1. if he does, I'll update the client in Debezium before we ship Beta1.

@sean-k1
Copy link
Author

sean-k1 commented Jan 8, 2024

@osheroff It's been a while :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TABLE_MAP deserialization Error with conflicting charsets
2 participants