Draft: use group algebra for characters #4334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
WIP
|
After talking to @felix-roehrich about this, we decided to not go down the route with group algebras, but stay with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I talked to you (@felix-roehrich ) about yesterday. The first three commits are a nice improvement IMO. From the fourth commit, I am not convinced, in particular that this new approach has a usability benefit over
Dict{WeightLatticeElem, ZZRingElem}. And the printing it gets less readable as well. Let's talk again about this in the office in the upcoming days.Some notes: This needs thofma/Hecke.jl#1688 dev'ed to work. The PR head is currently set to #4297 (which is included here as well) to only show any newer changes in the github UI.
I didn't yet invest time into fixing the tests, they just need a lot of type conversions...