Cartan eilenberg resolutions #4248
Merged
+275
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4248 +/- ##
==========================================
- Coverage 84.59% 84.59% -0.01%
==========================================
Files 631 632 +1
Lines 85064 85177 +113
==========================================
+ Hits 71960 72054 +94
- Misses 13104 13123 +19
|
|
@wdecker is dealing with it |
|
Looks good from my side. |
lgoettgens
reviewed
Nov 13, 2024
| @@ -414,7 +414,7 @@ function set_grading!(M::FreeMod, W::Vector{<:IntegerUnion}) | |||
| M.d = [W[i] * A[1] for i in 1:length(W)] | |||
| end | |||
|
|
|||
| function degrees(M::FreeMod) | |||
| function degrees(M::FreeMod; check::Bool=true) | |||
There was a problem hiding this comment.
What is this check argument for? I am asking because it is not used in the function body. Is it just for consistency with other module types?
There was a problem hiding this comment.
It's for compatibility with the other signatures, yes.
|
Can this be merged? I would like to rebase #4327 on this, once we're ready. |
joschmitt
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for adding Cartan-Eilenberg resolutions for complexes of modules.
I am working on this because I use it in a paper which I am going to present in this conference. This is still work in progress, but I want to keep it up to date with the current OSCAR and make sure that tests are running.