Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup fix: Property 'transitionEnd' is never assigned, so banner doesn't set display to 'none' after it fades + broken unit test #910

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ryco404
Copy link

@ryco404 ryco404 commented Jun 21, 2024

The transitionEnd property is never assigned when checking the compatibie transition class meaning that the correct transitionEnd event is never listened to, meaning that display: none never gets set after the popup fades, so the popup window, in the case of revocable popups, when faded will still occlude elements on the page.

Also fixed broken unit test, the 'updates content options link and messagelink' test fails when running Jest, this is due to the regionalLaw property being missing on the passed in options, but also missed on the default object, meaning that it never gets merged, so the property will always be undefined - even when set on the options object.

…n't set display to 'none' after it fades + broken unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant