Ensure match reboot for autoyast test on yast X86_64 #20872
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjluo
force-pushed
the
ay_reboot
branch
2 times, most recently
from
0b84403 to
436a9f3
Compare
hjluo
changed the title
lemon-suse
reviewed
Dec 27, 2024
| @@ -129,7 +129,7 @@ sub run { | |||
| # Autoyast reboot automatically without confirmation, usually assert 'bios-boot' that is not existing on zVM | |||
| # So push a needle to check upcoming reboot on zVM that is a way to indicate the stage done | |||
| # For bsc#1231522, need match reboot popup on powerVM to reboot after installation. | |||
| push @needles, 'autoyast-stage1-reboot-upcoming' if is_s390x || (is_pvm && !is_upgrade && is_sle('<15-SP7')) || (check_var('VIRSH_VMM_FAMILY', 'xen') && check_var('VIRSH_VMM_TYPE', 'hvm')); | |||
There was a problem hiding this comment.
Please add comments for the reason to exclude of hvm.
There was a problem hiding this comment.
Added comment there. please take a look again. thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure match reboot for autoyast test on yast X86_64