Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SELINUX=0 to tw upgrade and zdup tests (bsc#1230118) #522

Closed
wants to merge 1 commit into from

Conversation

ca-hu
Copy link

@ca-hu ca-hu commented Oct 1, 2024

except to tw2tw zdup tests.

We want to toggle SELINUX=1 as default in tw tests to be able to test SELinux when it will be set as default in the installer. However, when going from Leap to tw, AppArmor should be preserved and tested, as we don't change the main LSM in these cases.

see:
os-autoinst/os-autoinst-distri-opensuse#20125

except to tw2tw zdup tests.

We want to toggle SELINUX=1 as default in tw tests to be able
to test SELinux when it will be set as default in the installer.
However, when going from Leap to tw, AppArmor should be preserved
and tested, as we don't change the main LSM in these cases.

see:
os-autoinst/os-autoinst-distri-opensuse#20125
Copy link
Member

@Vogtinator Vogtinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether the job group is the right option compared to modifying the test suite, but it depends on the product whether the upgrade enables SELINUX or not, so it's probably the best option

@ca-hu ca-hu marked this pull request as ready for review October 1, 2024 13:11
@ca-hu
Copy link
Author

ca-hu commented Nov 25, 2024

probably better to fix up the test suite, closing

@ca-hu ca-hu closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants