feat: Forward original authorization header when using remote (json) authorizer #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepatrik
reviewed
Oct 8, 2020
pipeline/authz/remote_json.go
Outdated
| @@ -84,6 +84,7 @@ func (a *AuthorizerRemoteJSON) Authorize(_ *http.Request, session *authn.Authent | |||
| return errors.WithStack(err) | |||
| } | |||
| req.Header.Add("Content-Type", "application/json") | |||
| req.Header.Add("Authorization", r.Header.Get("Authorization")) | |||
There was a problem hiding this comment.
What happens when there is no Authorization header in the original request? Looks like it will still be set, then to an empty string?
There was a problem hiding this comment.
mmm, that's not so nice i guess. changed to only forward if authz header is non-empty
There was a problem hiding this comment.
can you maybe also add a test case for that? thanks 😉
aeneasr
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#528
Proposed changes
Sometimes the user/subject from the authSession is not enough when attempting to make informed access control decisions. This PR grants access to the authorization header from the original request when using the
remoteandremote_jsonauthorizers so that additional information can be extracted from the token if need be.Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further comments
n/a