feat: Decorate request logs with trace_id and span_id fields #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your work on this! I'd like to take this but I want to move it to another place because we're currently refactoring the logger. Is it ok if I keep this open and integrate this work into our new logging component? |
claudio-benfatto
force-pushed
the
feat-enable_opetracing_fields_in_logs
branch
from
6b4dd0e
to
56f2fce
Compare
Hi @aeneasr of course yes, no problem at all! Thanks! |
|
Sorry that I didn't have time to work on this. Cleaning up old issues and closing this one but keeping it tracked for #441 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Proposed changes
This PR introduces
opentracing,trace_idandspan_idrequest tracing fields to theapiandproxyhandlers.The implementation is very similar to: ory/hydra#1685.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further comments
In this PR I opted for decorating the logs with a private method in the
serverpackage. However, and given the fact that this is already the second project (up to my knowledge) introducing this feature, would it make sense to add the code to the reqlog package