-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: oauth2/revoke api fewer parameter as required in doc #3261
base: master
Are you sure you want to change the base?
Conversation
client_id and client_secret are mandatory in token revoke api
Codecov Report
@@ Coverage Diff @@
## master #3261 +/- ##
=======================================
Coverage 76.80% 76.80%
=======================================
Files 123 123
Lines 8845 8845
=======================================
Hits 6793 6793
Misses 1627 1627
Partials 425 425 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for your PR. :)
Unfortunately, these files are generated by a generator, so manually changing them does not work, as they will be overridden the next time someone runs the generation.
But, fixing that is easy:
- Go to https://github.com/ory/hydra/blob/master/oauth2/handler.go#L578
- Add
ClientID
andClientSecret
to therevokeOAuth2Token
struct with the appropriate tags and comments (these are what defines what to generate!) - Run
make sdk
in the root of the repository
The last step will update/generate a few other files as well - these are necessary and should be committed, too.
And another note: since the time you opened the PR we updated the Go version to 1.19 in this repository. That introduced a few formatting changes, so please update the state on your branch (rebase or merge) and make sure to run make sdk
from a shell that has Go 1.19 active (check via go version
) to not introduce formatting issues.
Thanks again for providing this PR! :)
client id and client secret are mandatory in oauth2/revoke api
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments