Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom image name configuration #1072

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

paul-kang-1
Copy link
Contributor

Changelog

Details

Although I initially attempted to find a way to only replace the registry name, there wasn't a clean way to separate the registry name from the repository name. For example, the registry of the image docker.io/library/mongo:latest would be docker.io/library (everything before the last slash), whilst the registry for docker.io/mysql/mysql-server:latest would simply be docker.io.

With such ambiguity, it would be better to let the user to define both the registry name and the repository name. (Also if one uses a custom registry, the subdirectories of the repository name would likely differ anyways)

Another way to implement this feature could be to redefine the internal representation of images from string to a custom type w/ internal fields for registry/repository/name, etc. However, this would require changing the image definitions for all presets, but may be more flexible in the long run.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.54%. Comparing base (97f7ed9) to head (326f3b5).
Report is 34 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (97f7ed9) and HEAD (326f3b5). Click for more details.

HEAD has 14 uploads less than BASE
Flag BASE (97f7ed9) HEAD (326f3b5)
17 3
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1072       +/-   ##
===========================================
- Coverage   85.87%   33.54%   -52.33%     
===========================================
  Files          50       55        +5     
  Lines        2350     2623      +273     
===========================================
- Hits         2018      880     -1138     
- Misses        173     1665     +1492     
+ Partials      159       78       -81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orlangure orlangure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this 😼
Looks great!

@orlangure orlangure merged commit b57afd8 into orlangure:master Jul 9, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Configurable Docker Registry URL
2 participants