Add custom image name configuration #1072
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
WithCustomImage
functionDetails
Although I initially attempted to find a way to only replace the registry name, there wasn't a clean way to separate the registry name from the repository name. For example, the registry of the image
docker.io/library/mongo:latest
would bedocker.io/library
(everything before the last slash), whilst the registry fordocker.io/mysql/mysql-server:latest
would simply bedocker.io
.With such ambiguity, it would be better to let the user to define both the registry name and the repository name. (Also if one uses a custom registry, the subdirectories of the repository name would likely differ anyways)
Another way to implement this feature could be to redefine the internal representation of images from string to a custom type w/ internal fields for registry/repository/name, etc. However, this would require changing the image definitions for all presets, but may be more flexible in the long run.