Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

styles(ui): scss and ts linting errors fixed #2890

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

styles(ui): scss and ts linting errors fixed #2890

wants to merge 2 commits into from

Conversation

gpazuch
Copy link
Contributor

@gpazuch gpazuch commented Dec 19, 2023

  • update package.json lint, lint:styles and lint:styles:fix targets
  • manually fix scss files (stylelint not autofixing some errors)
  • update .stylelintrc.json defaultSeverity to 'warning'
  • fix ./src/**.ts files with lint:fix
  • manually fix shadowed var names

@gpazuch
style(ui): Fix stylelint errors
5295c41 
* manually fix scss style errors
* update package.json targets `lint:styles` and `lint:styles:fix`
* update .stylelintrc.json to defaultSeverity 'warning'
@gpazuch
style(ui): fix .ts linting errors
9b253d0 
* fix package.json target `lint` to use tslint instead of ng lint
* fix source files with `lint:fix`
lpegoraro
lpegoraro approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@lpegoraro lpegoraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpegoraro lpegoraro mentioned this pull request Dec 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpegoraro lpegoraro lpegoraro approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
javascript json typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gpazuch @lpegoraro