checking naming via clang-tidy

.clang-tidy

@@ -1,4 +1,5 @@
 Checks:          '-checks=-*,bugprone-*,clang-analyzer-*,cppcoreguidelines-*,modernize-*,readability-*,
+                  -bugprone-unchecked-optional-access,
                   -cppcoreguidelines-avoid-c-arrays,
                   -cppcoreguidelines-avoid-do-while,
                   -cppcoreguidelines-avoid-magic-numbers,
@@ -33,4 +34,18 @@ CheckOptions:
       value: true
     - key: modernize-use-override.IgnoreDestructors
       value: 1
+    - key: readability-identifier-naming.ClassCase
+      value: Camel_Snake_Case
+    - key: readability-identifier-naming.ClassMemberCase
+      value: lower_case
+    - key: readability-identifier-naming.MemberPrefix
+      value: 'm_'
+    - key: readability-identifier-naming.ClassMethodCase
+      value: lower_case
+    - key: readability-identifier-naming.ConstexprVariableCase
+      value: UPPER_CASE
+    - key: readability-identifier-naming.StaticConstantCase
+      value: UPPER_CASE
+    - key: readability-identifier-naming.LocalVariableCase
+      value: lower_case
 ...

TODO

@@ -2,4 +2,3 @@
 - make cross compilation work again
 - consider removing ECB namespace
 - consider using spdlog
-- checking naming convention via clang-tidy

src/Data_Loader.cpp

@@ -26,7 +26,7 @@ namespace ECB
         return {};
     }
 
-    std::vector<Record> Data_Loader::load_from_url(const std::string &url, const std::string &save_to_file)
+    std::vector<Record> Data_Loader::load_from_url(const std::string &url, std::string_view save_to_file)
     {
         try
         {
@@ -36,7 +36,7 @@ namespace ECB
             {
                 if (!save_to_file.empty())
                 {
-                    std::ofstream file(save_to_file);
+                    std::ofstream file(save_to_file.data());
                     file << r.text;
                     file.close();
                 }
@@ -78,7 +78,7 @@ namespace ECB
         auto root = doc.first_child();  // "gesmes:Envelope" is the name
         auto cube = root.child("Cube"); // root of all currency data
 
-        const std::string BASE{"EUR"};
+        static const std::string BASE{"EUR"};
         for (const auto &day_node: cube.children()) // each child is also "Cube"
         {
             std::string time = day_node.attribute("time").as_string();

src/Data_Loader.hpp

@@ -17,7 +17,7 @@ namespace ECB
 
         // Load data from a url and return a vector of records.
         // Returns an empty vector if the data could not be loaded.
-        static std::vector<Record> load_from_url(const std::string &url, const std::string &save_to_file = "");
+        static std::vector<Record> load_from_url(const std::string &url, std::string_view save_to_file = "");
 
     private:
         // Load data from a string and return a vector of records.

src/Server_Impl.cpp

@@ -46,7 +46,7 @@ namespace ECB
         if (uri->len != TEMPLATE.size())
             return false;
 
-        // uri len is the same as the template
+        // uri len is the same as the TEMPLATE
         for (size_t pos = 0; pos < uri->len; ++pos)
         {
             const char c = uri->ptr[pos];