unbound: discard-timeout #7512
unbound: discard-timeout #7512
Conversation
Signed-off-by: Nigel Jones <[email protected]>
| from accumulating. | ||
| If 'Serve Expired Responses' is enabled it should be set greater than 'Client Expired Response Timeout'. | ||
| Otherwise, a value of 1900 msec is suggested. | ||
| The value 0 disables it. Default 1900 msec. |
There was a problem hiding this comment.
"0" could be problematic which may be indistinguishable from "" (the empty default), but I leave that for @swhite2 to check
There was a problem hiding this comment.
I know serve-expired-ttl (which we use) has a similar use of 0 as per the unbound doc
I just checked - and if I leave the value blank in the opnsense UI, no value is written to the configuration for discard-timeout. Once I set a value, it is written. Finally, if I specifically put 0 there, that does get written.
So I think in all cases it matches the unbound docs ?
Co-authored-by: Franco Fichtner <[email protected]>
|
Small nitpick, but looks good! |
|
Oh, one more thing: in the ticket you said
Perhaps this can be included in the help text as well |
Adds support for 'discard-timeout' to Unbound configuration.
This can be useful when using the option to serve expired responses.
The new option is added just below 'Jostle Timeout' within the advanced panel.
I did consider adding it within the serve-expired section, however it's not strictly as tightly related and has more general applicability (as per unbound docs). I also removed once sentence (for help) which made no sense from the unbound docs, and clarified the exact labels used for related settings in the UI.
I tested with a 'live' install to ensure the panel worked, and the value was then placed into /var/unbound/advanced.conf
Based off master
Fixes #7493