Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#59914] Add times for labor costs to the cost report and export #17450

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

as-op
Copy link
Contributor

@as-op as-op commented Dec 12, 2024

Ticket

https://community.openproject.org/work_packages/59914

What are you trying to accomplish?

Display the start and end times of a TimeEntry in the costs view and the excel export. (If activated by Setting.allow_tracking_start_and_end_times)

Screenshots

If the unit "Labor" is selected and no grouping is selected
cost_query

In exported excel sheet "Labor"
excel

What approach did you choose and why?

  • Moved some code from PDF Timesheet to helper for reuse
  • Split up table code to insert the column(s) after the spent_on column.
  • In the excel sheet there are separate columns for each time.

Merge checklist

  • Added/updated tests
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17450 December 12, 2024 21:35 Inactive
@as-op as-op changed the title [#59914] Add times for labour costs to the cost report and export [#59914] Add times for labor costs to the cost report and export Dec 16, 2024
@as-op as-op marked this pull request as ready for review December 16, 2024 11:41
@as-op as-op marked this pull request as draft December 16, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants