Add annotations to service #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2105f14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
crohr
reviewed
Aug 19, 2024
| end | ||
|
|
||
| it 'adds the default secrets', :aggregate_failures do | ||
| annotations = template.dig("Service/optest-openproject", "metadata", "annotations") |
There was a problem hiding this comment.
@oliverguenther what's the expected behaviour here? should it merged any existing annotation with the user-provided ones? (I would assume yes). Should we add a test about it?
There was a problem hiding this comment.
I can only test the input from the values in the specs, it doesn't use any real nodes or helm deployments. But I would assume that kubernetes merges those?
|
@machisuji @crohr Is still this required for the EKS setup? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.