Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't fail release if version didn't change #18

Merged
merged 2 commits into from
Feb 21, 2024
Merged

ci: don't fail release if version didn't change #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d49650
ci: don't fail release if version didn't change
Feb 21, 2024
a3faaf6
no chores
Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions build-bin/helm/helm_prepare
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

trigger_tag=${1?trigger_tag is required. Ex release-1.2.3}
release_version=$(build-bin/git/version_from_trigger_tag release- ${trigger_tag})
latest_app_version=${2?latest_app_version is required. Ex 4.5.6}
release_branch=${3:-master}

# Checkout master, as we release from master, not a tag ref
Expand All @@ -32,14 +33,15 @@ if [ "$commit_local_release_branch" != "$commit_remote_release_branch" ]; then
fi

# Update appVersion
latest_app_version=${2?latest_app_version is required. Ex 4.5.6}
sh -c "sed -i 's/appVersion\:\s[0-9.]\+/appVersion\: ${latest_app_version}/g' ./charts/zipkin/Chart.yaml"

# Update version
sh -c "sed -i 's/version\:\s[0-9.]\+/version\: ${release_version}/g' ./charts/zipkin/Chart.yaml"

# Commit changes to ./charts/zipkin/Chart.yaml
git add ./charts/zipkin/Chart.yaml && git commit -m "chore: prepare chart release ${release_version}"
git add ./charts/zipkin/Chart.yaml

# Push the changes in ./charts/zipkin/Chart.yaml to the release branch
git push origin ${release_branch}
if git commit -m "release: updates for ${release_version}"; then
# Push the changes in ./charts/zipkin/Chart.yaml to the release branch
git push origin ${release_branch}
fi
Loading