Skip to content

Commit

Permalink
Add extraManifests value (#27)
Browse files Browse the repository at this point in the history
  • Loading branch information
CiucurDaniel authored Nov 19, 2024
1 parent 9ae8208 commit fe57c92
Show file tree
Hide file tree
Showing 5 changed files with 32 additions and 0 deletions.
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ You can then run `helm search repo zipkin` to see the charts.
| zipkin.storage.elasticsearch.username | string | no default | Basic authentication of X-Pack security |
| zipkin.storage.elasticsearch.password | string | no default | Basic authentication of X-Pack security |
| zipkin.storage.type | string | `"mem"` | |
| extraManifests | list | `[]` | Extra manifests to deploy with the helm chart |



The values are validated using a JSON schema, which contains logic to enforce either:

Expand Down
13 changes: 13 additions & 0 deletions charts/zipkin/ci/extraManifests-values.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
extraManifests:
- apiVersion: v1
kind: ConfigMap
metadata:
name: some-config
data:
example: true
- apiVersion: v1
kind: ConfigMap
metadata:
name: some-other-config
data:
example: true
4 changes: 4 additions & 0 deletions charts/zipkin/templates/extra-objects.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{{ range .Values.extraManifests }}
---
{{ tpl (toYaml .) $ }}
{{ end }}
3 changes: 3 additions & 0 deletions charts/zipkin/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,9 @@
"type": "object"
}
}
},
"extraManifests": {
"type": "object"
}
}
}
9 changes: 9 additions & 0 deletions charts/zipkin/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -143,3 +143,12 @@ extraServicePorts: []

# global variables to use in values. typically used in tests.
global: {}

# extra manifests to deploy with the helm chart
extraManifests: []
# - apiVersion: v1
# kind: ConfigMap
# metadata:
# name: some-config
# data:
# example: true

0 comments on commit fe57c92

Please sign in to comment.