Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs-create(8): ZFS for swap: caution, clarity #16906

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

makhomed
Copy link

Make the section heading more generic (the section relates to ZFS files as well as ZFS volumes).

Swapping to a ZFS volume is prone to deadlock. Remove the related instruction, direct readers to OpenZFS FAQ. Related, but not linked from within the manual page:

https://openzfs.github.io/openzfs-docs/Project%20and%20Community/FAQ.html#using-a-zvol-for-a-swap-device-on-linux (Using a zvol for a swap device on Linux).

Reviewed-by: Brian Behlendorf [email protected]
Signed-off-by: Graham Perrin [email protected]
Issue #7734
Closes #14756
(cherry picked from commit 6c29422)

Motivation and Context

Fixes issue #16891

Description

cherry picked from commit 6c29422

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Make the section heading more generic (the section relates to ZFS files
as well as ZFS volumes).

Swapping to a ZFS volume is prone to deadlock. Remove the related
instruction, direct readers to OpenZFS FAQ. Related, but not linked
from within the manual page:

<https://openzfs.github.io/openzfs-docs/Project%20and%20Community/FAQ.html#using-a-zvol-for-a-swap-device-on-linux>
(Using a zvol for a swap device on Linux).

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Graham Perrin <[email protected]>
Issue #7734
Closes #14756
(cherry picked from commit 6c29422)
@amotin amotin added the Status: Accepted Ready to integrate (reviewed, tested) label Dec 27, 2024
@makhomed
Copy link
Author

makhomed commented Dec 27, 2024

"Changes approved", but "Merging is blocked" for me, because two zfs-tests-functional are failed.

I am not authorized to merge this pull request.

image

@amotin amotin merged commit 5beeabe into openzfs:zfs-2.1.17-staging Dec 27, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong information inside the zfs-create man page on the 2.1-release branch
5 participants