Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "no name changes" from compression to checksum table #16776

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

robn
Copy link
Member

@robn robn commented Nov 17, 2024

[Sponsors: Klara, Inc., Wasabi Technology, Inc.]

Motivation and Context

A comment that confused me. Compression names actually aren't used in dedup table names, but checksum names are.

Was introduced in review #15892 (comment).

Description

Moved the comment (and de-shouted it) to where I think it should have been.

I wonder how necessary this really is. It's not wrong, but I expect there's lots of things that are stored on disk that aren't immediately obvious, so it feels weird to call out just this case. On the other hand, maybe this is just a step towards someday calling them all out, so its no big deal :)

How Has This Been Tested?

Comment change. no testing done.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Compression names actually aren't used in dedup table names, but
checksum names are.

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Signed-off-by: Rob Norris <[email protected]>
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Nov 18, 2024
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 19, 2024
@behlendorf behlendorf merged commit ffe2112 into openzfs:master Nov 19, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants