Move "no name changes" from compression to checksum table #16776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Sponsors: Klara, Inc., Wasabi Technology, Inc.]
Motivation and Context
A comment that confused me. Compression names actually aren't used in dedup table names, but checksum names are.
Was introduced in review #15892 (comment).
Description
Moved the comment (and de-shouted it) to where I think it should have been.
I wonder how necessary this really is. It's not wrong, but I expect there's lots of things that are stored on disk that aren't immediately obvious, so it feels weird to call out just this case. On the other hand, maybe this is just a step towards someday calling them all out, so its no big deal :)
How Has This Been Tested?
Comment change. no testing done.
Types of changes
Checklist:
Signed-off-by
.