FreeBSD: Use the new freeuio() helper to free dynamically allocated UIOs #16300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotin
reviewed
Jun 26, 2024
This freeuio() interface was introduced to FreeBSD recently. For now it simply calls free(), so this change has no effect. However, this may not always be true, and in CheriBSD this change is required. Signed-off-by: Mark Johnston <[email protected]>
amotin
approved these changes
Jun 26, 2024
brooksdavis
approved these changes
Jun 27, 2024
tonyhutter
reviewed
Jun 28, 2024
| static void | ||
| zfs_freeuio(struct uio *uio) | ||
| { | ||
| #if __FreeBSD_version > 1500013 |
There was a problem hiding this comment.
just double checking, should this be >= or >?
There was a problem hiding this comment.
> is correct. __FreeBSD_version was not bumped when freeuio() was added to FreeBSD, and its value at the time was 1500013. This change won't compile for previous revisions after the bump from 1500012 to 1500013, to be safe we can just consider 1500014 to be the first version which includes freeuio().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
FreeBSD now has a helper function to free UIOs returned by cloneuio(). Use that instead of calling free() directly.
Description
FreeBSD has a new interface for freeing UIOs, freeuio(). Use that when on a sufficiently new kernel. This has no effect for now but it may be necessary in the future.
How Has This Been Tested?
Build-tested.
Types of changes
Checklist:
Signed-off-by.