Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail to install dependencies if kernel headers fail on Debian #262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rincebrain
Copy link
Contributor

As the buildbot shows right now, if the big monolithic apt-get command has a package missing (say, linux-headers-4.19.0-11-arm64), it will fail to install any of them.

Since breaking it into a bunch of install commands would increase the runtime substantially, just break out the headers install to a separate command, have it fall back to trying to install the latest headers for the arch anyway, and then install the other dependencies separately, so hopefully the erroring next time requires less digging to figure out the kernel headers were missing, not zlib1g-dev.

(Technically it having any headers could make it succeed and fail to load modules later, but since I suspect what's happening is the initial VM bringup is slightly too old so its headers are no longer in the repo, either we try with the latest headers assuming we're going to be using that kernel version, or we fail until someone updates the base VM.

If we want to be sure we boot the latest kernel, of course, we could explicitly install that...)

As [the buildbot shows](http://build.zfsonlinux.org/builders/Debian%2010%20arm64%20%28BUILD%29) right now, if the big monolithic apt-get command has a package missing (say, linux-headers-4.19.0-11-arm64), it will fail to install any of them.

Since breaking it into a bunch of install commands would increase the runtime substantially, just break out the headers install to a separate command, have it fall back to trying to install the latest headers for the arch anyway, and then install the other dependencies separately, so hopefully the erroring next time requires less digging to figure out the kernel headers were missing, not zlib1g-dev.
@behlendorf
Copy link
Contributor

Sorry I missed this. The Debian repositories sorted out whatever their issue was but this still seems like a good idea. I'll see about getting it pulled in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants