Add support for P384 #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the C_1 in all cases. (The specification makes it optional, but this library supports only the case in which it is present -- further changes are expected in -07 on this anyway).
by generalizing over the P256 code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds to #22 by fixing support for ciphersuite 5 (which I added earlier, but could not test in full; now it has at least exchanged with my own implementation).
The same generalization as done here can not be applied to the X25519/X448 paragraphs above, as they only provide their respective PrivateKey classes in curve_obj from pycose; it may make sense to split curve_obj up into the respective underlying classes -- not sure if an EC2 key's curve_obj interface is even compatible with OPK's, so maybe they could be named differently at all or just a property for the public thing be added.