Support of --method, --body-data and --body-file #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The var means that ether --post-data or --post-file was set. Remove duplicated code to set the Content-Type header. Signed-off-by: Sergey Ponomarev <[email protected]>
In GNU wget the --spider first issues a HEAD request, then if HEAD fails, issues a GET request. In uclient, only a GET request is sent. The patch changes GET to HEAD e.g. get the file size without downloading it first. This is still not totally compatible with GNU wget because it does not retry with GET if HEAD fails. Someone may use the --spider to call a GET only API, so they may be affected. But this is incorrect usage while others may expect that the spider uses HEAD and don't expect a download. Signed-off-by: Sungbo Eo <[email protected]> Signed-off-by: Sergey Ponomarev <[email protected]>
The --method allows executing PUT, DELETE, OPTIONS, HEAD e.g.:
wget -O - -q \
--method=PUT \
--body-data='{"id": 42}' \
--header='Content-Type: application/json' \
http://api.example.com/
To avoid clashes with the --post-data/file options,
the separate --body-data/file must be used.
They are stored to the same post_data and post_data vars.
Mutual usage of the options is not allowed, same as in GNU wget.
Signed-off-by: Sergey Ponomarev <[email protected]>
|
Looks good to me! I like how it cleans up the Content-Type header logic. I noticed that |
|
Thank you, Old patch from 2020 https://patchwork.ozlabs.org/project/openwrt/patch/CADR0UcUXJS4DkSSR_0-ZKhdEOaOwUn09WpJDpG9NMRYNsjQ8Sw@mail.gmail.com/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR allows to set a custom method e.g. PUT, DELETE but only that supported by the
request_typeenum.This opens a way to use most of modern REST APIs:
You may send a body:
@dhewg @dangowrt @mans0n @efahl @ynezz please review