Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide semi-sl recipes from tests #4144

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Hide semi-sl recipes from tests #4144

merged 2 commits into from
Dec 5, 2024

Conversation

sovrasov
Copy link
Contributor

@sovrasov sovrasov commented Dec 4, 2024

Summary

That allows to reduce CI usage

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added the TEST Any changes in tests label Dec 4, 2024
@kprokofi
Copy link
Collaborator

kprokofi commented Dec 4, 2024

Why do we need to change yaml to yml?
If it is for tests filtering, could we just add "if" condition?

@sovrasov
Copy link
Contributor Author

sovrasov commented Dec 4, 2024

Why do we need to change yaml to yml? If it is for tests filtering, could we just add "if" condition?

I decided not to pollute code of the tests. Anyway, these files are to be deleted, also I'd have been searching through several test files in that case to disable semi sl everywhere.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.51%. Comparing base (31823cd) to head (469e91e).
Report is 55 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4144      +/-   ##
===========================================
+ Coverage    77.11%   80.51%   +3.40%     
===========================================
  Files          308      320      +12     
  Lines        30571    31492     +921     
===========================================
+ Hits         23576    25357    +1781     
+ Misses        6995     6135     -860     
Flag Coverage Δ
py310 80.50% <ø> (+3.39%) ⬆️
py311 80.32% <ø> (+3.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sovrasov sovrasov merged commit 0215326 into develop Dec 5, 2024
22 checks passed
@sovrasov sovrasov deleted the vs/hide_semi_sl branch December 5, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants