-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARM]: Implement CPU plugin just-in-time emitter for Erf operation #27499 #28176
base: master
Are you sure you want to change the base?
Conversation
const TReg src(in_vec_idxs[0]); | ||
const TReg dst(out_vec_idxs[0]); | ||
|
||
h->erf(dst.s, src.s); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw your comment with asking help about erf impl (but seems like it was deleted).
You can take a look on JIT Emitter for GeluErf for AArch64 platforms. There is Erf impl
Also, we have JIT Emitter for Erf for x64 platforms. Please take a look - it might be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I checked out the ERF approximation and also the ERF documentation in general. I assume that we have to use the approximation formula to implement ERF. Also can I directly use the same idea from the JIT Emitter for ERF for x64 and then port accordingly for AArch64?
Also, I work on a windows laptop, are there any steps to test this on windows? Sorry for the dumb doubts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also can I directly use the same idea from the JIT Emitter for ERF for x64 and then port accordingly for AArch64?
For sure! It makes sense 😃
Also, I work on a windows laptop, are there any steps to test this on windows? Sorry for the dumb doubts
I'd assume that your laptop is on x64 arch (intel or amd). In this case you need emulator to launch programs for arm64. But to be honest, I don't know any good options to do it on windows.
I know only one option with WSL - there you can use cross-compilation and launch programs with QEMU.
Sorry for the dumb doubts
No worries, everything is ok! 👍🏼
Details:
Tickets:
#27499