Android Screen Sharing #458
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still crashing , showing sensitive info content and crashing |
# Conflicts: # android/src/main/java/com/opentokreactnative/OTSessionManager.java
fix: incorrect audio bitrate sanitization
fix: audio crash on teardown
|
@rrnara I cannot seem to get it to work. I edit the manifest file of the app, not the library right? Does it work on the emulator |
|
@abdulajet Can you try installing this package and see how it works: https://www.npmjs.com/package/@rrnara/opentok-react-native? Because that is what we are doing for our app |
|
will do when i get a chance! thanks |
added 2 commits
June 3, 2021 10:43
# Conflicts: # CHANGELOG.md # package-lock.json # package.json
|
Is someone reviewing this changes yet? |
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.4 to 0.8.5. - [Release notes](https://github.com/shelljs/shelljs/releases) - [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md) - [Commits](shelljs/shelljs@v0.8.4...v0.8.5) --- updated-dependencies: - dependency-name: shelljs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [react-native](https://github.com/facebook/react-native) from 0.64.0 to 0.64.1. - [Release notes](https://github.com/facebook/react-native/releases) - [Changelog](https://github.com/facebook/react-native/blob/main/Releases.md) - [Commits](facebook/react-native@v0.64.0...v0.64.1) --- updated-dependencies: - dependency-name: react-native dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.1...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.2 to 6.12.6. - [Release notes](https://github.com/ajv-validator/ajv/releases) - [Commits](ajv-validator/ajv@v6.10.2...v6.12.6) --- updated-dependencies: - dependency-name: ajv dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.0 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.0...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [plist](https://github.com/TooTallNate/node-plist) from 3.0.2 to 3.0.4. - [Release notes](https://github.com/TooTallNate/node-plist/releases) - [Changelog](https://github.com/TooTallNate/plist.js/blob/master/History.md) - [Commits](https://github.com/TooTallNate/node-plist/commits) --- updated-dependencies: - dependency-name: plist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](caolan/async@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…sync-2.6.4 Bump async from 2.6.3 to 2.6.4
…inimist-1.2.6 Bump minimist from 1.2.5 to 1.2.6
…list-3.0.4 Bump plist from 3.0.2 to 3.0.4
…ollow-redirects-1.14.8 Bump follow-redirects from 1.14.0 to 1.14.8
…jv-6.12.6 Bump ajv from 6.10.2 to 6.12.6
…mpl-1.0.5 Bump tmpl from 1.0.4 to 1.0.5
…ode-fetch-2.6.7 Bump node-fetch from 2.6.1 to 2.6.7
…helljs-0.8.5 Bump shelljs from 0.8.4 to 0.8.5
…ath-parse-1.0.7 Bump path-parse from 1.0.6 to 1.0.7
…eact-native-0.64.1 Bump react-native from 0.64.0 to 0.64.1
* update android to 2.21.5 * - update readme with bintray * typos corrected * - fix audioLevel type * update JDK version Co-authored-by: Abdulhakim Ajetunmobi <[email protected]>
Bumps [plist](https://github.com/TooTallNate/node-plist) from 3.0.2 to 3.0.5. - [Release notes](https://github.com/TooTallNate/node-plist/releases) - [Changelog](https://github.com/TooTallNate/plist.js/blob/master/History.md) - [Commits](https://github.com/TooTallNate/node-plist/commits) --- updated-dependencies: - dependency-name: plist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/chalk/ansi-regex/releases) - [Commits](chalk/ansi-regex@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: ansi-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…com/opentok/opentok-react-native into updates-from-dependantbot
…nsi-regex-4.1.1 Bump ansi-regex from 4.1.0 to 4.1.1
…k/opentok-react-native into updates-from-dependantbot
Updates from dependantbot
|
@abdulajet what should/will happen to this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current Android Screen share doesn't share the screen when the user leaves the app. This change will use the MediaProjection service to share the screen which allows to work outside the app context. It also shows a dialog to use when screen share begins and display a notification center info that app is sharing screen.
Contributing checklist
Solves issue(s)
#457