Skip to content

Commit

Permalink
Merge pull request #759 from opentok/develop
Browse files Browse the repository at this point in the history
v2.27.6
  • Loading branch information
jeffswartz authored Jun 26, 2024
2 parents 6001f86 + cec8859 commit 93b005b
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/sample_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup Xcode version
uses: maxim-lobanov/[email protected]
with:
xcode-version: '13.1'
xcode-version: '14.3.1'
- name: Pack Library
run: |
npm pack
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 2.27.6 (June 2024)

- [Fix]: This version fixes some iOS crashes that were introduced in version 2.27.5. Fixes issue #757.

# 2.27.5 (June 2024)

- [Fix]: This version fixes the `OTSubscriber captionReceived` event handler. It also fixes the `OTPublisher publishCaptions` option in iOS.
Expand Down
4 changes: 2 additions & 2 deletions ios/OpenTokReactNative/OTSessionManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ extension OTSessionManager: OTPublisherDelegate {
let publisherId = Utils.getPublisherId(publisher as! OTPublisher);
if (publisherId.count > 0) {
OTRN.sharedState.isPublishing[publisherId] = true;
let streamInfo: Dictionary<String, Any> = EventUtils.prepareJSStreamEventData(stream);
var streamInfo: Dictionary<String, Any> = EventUtils.prepareJSStreamEventData(stream);
streamInfo["publisherId"] = publisherId;
self.emitEvent("publisherStreamCreated", data: streamInfo);
setStreamObservers(stream: stream, isPublisherStream: true)
Expand All @@ -667,7 +667,7 @@ extension OTSessionManager: OTPublisherDelegate {
OTRN.sharedState.isPublishing[publisherId] = false;
if (publisherId.count > 0) {
OTRN.sharedState.isPublishing[publisherId] = false;
let streamInfo: Dictionary<String, Any> = EventUtils.prepareJSStreamEventData(stream);
var streamInfo: Dictionary<String, Any> = EventUtils.prepareJSStreamEventData(stream);
streamInfo["publisherId"] = publisherId;
self.emitEvent("publisherStreamDestroyed", data: streamInfo);
}
Expand Down
6 changes: 3 additions & 3 deletions ios/OpenTokReactNative/Utils/EventUtils.swift
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,8 @@ class EventUtils {
"\(sessionPreface)connectionCreated",
"\(sessionPreface)connectionDestroyed",
"\(sessionPreface)didFailWithError",
"\(publisherPreface)streamCreated",
"\(sessionPreface)signal",
"\(sessionPreface)muteForced",
"\(publisherPreface)streamDestroyed",
"\(publisherPreface)didFailWithError",
"\(publisherPreface)audioLevelUpdated",
"\(publisherPreface)rtcStatsReport",
Expand All @@ -162,7 +160,9 @@ class EventUtils {
"\(sessionPreface)sessionDidReconnect",
"\(sessionPreface)streamPropertyChanged",
"\(subscriberPreface)subscriberDidReconnect",
"\(subscriberPreface)subscriberCaptionReceived"
"\(subscriberPreface)subscriberCaptionReceived",
"publisherStreamCreated",
"publisherStreamDestroyed"
];
}

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "opentok-react-native",
"version": "2.27.5",
"version": "2.27.6",
"description": "React Native components for OpenTok iOS and Android SDKs",
"main": "src/index.js",
"homepage": "https://www.tokbox.com",
Expand Down

0 comments on commit 93b005b

Please sign in to comment.