Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove study_index_path from coloc step #791

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

project-defiant
Copy link
Contributor

✨ Context

This PR fixes issue with the ColocalisationStep that was updated with #782, but did not include the removal of the study_index_path from the hydra configuration.

🛠 What does this PR implement

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@github-actions github-actions bot added bug Something isn't working Step size-XS labels Sep 26, 2024
@project-defiant project-defiant requested review from vivienho and removed request for DSuveges September 26, 2024 15:12
@project-defiant project-defiant marked this pull request as ready for review September 26, 2024 15:12
Copy link
Contributor

@vivienho vivienho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@project-defiant project-defiant merged commit 9f83329 into dev Sep 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size-XS Step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants