Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small fixes in susie defaults #552

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

addramir
Copy link
Contributor

@addramir addramir commented Mar 20, 2024

✨ Context

Small PR that fixes defaults in SuSiE to canonical ones.

πŸ›  What does this PR implement

It switches off the estimation of inf effects as a default.

πŸ™ˆ Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@github-actions github-actions bot added bug Something isn't working size-S Method labels Mar 20, 2024
@addramir addramir marked this pull request as ready for review March 20, 2024 18:03
@addramir
Copy link
Contributor Author

@Daniel-Considine please review/approve.

@addramir addramir merged commit dee3085 into dev Mar 21, 2024
4 checks passed
@addramir addramir deleted the ytdc_susie_to_studylocus branch March 21, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Method size-S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants