Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sumstats): correct study id for dir of finngen studies #551

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

louwenjjr
Copy link
Contributor

@louwenjjr louwenjjr commented Mar 20, 2024

✨ Context

When input is a directory the study ids are not read correctly for finngen sumstats.

🛠 What does this PR implement

Extract finngen study_id by using f.input_file_name() instead of study_id = raw_file.split("/")[-1].split(".")[0].upper().

🙈 Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

Copy link
Contributor

@ireneisdoomed ireneisdoomed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a better approach and the pattern works as expected. Thank you for the contribution!!

(The harmonisation of all Finngen summary statistics is particularly tricky. The DAG currently sends one job per study, any optimisations here are welcome)

Please, update the branch with base.

@ireneisdoomed ireneisdoomed merged commit 255c42d into opentargets:dev Mar 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants