Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pr labeller patterns #523

Merged
merged 4 commits into from
Mar 7, 2024
Merged

fix: pr labeller patterns #523

merged 4 commits into from
Mar 7, 2024

Conversation

d0choa
Copy link
Collaborator

@d0choa d0choa commented Mar 6, 2024

✨ Context

PR labeler patterns don't start at the beginning of the paths. This is making a few incorrect tags to be added. For example:

  • Documentation in tests/docs/...
  • Refactor in PR title: perf: refactor clump
  • ...

🛠 What does this PR implement

Updated patterns starting with "^"

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@github-actions github-actions bot added bug Something isn't working size-S labels Mar 6, 2024
@d0choa d0choa changed the title fix: pr labeler patterns fix: pr labeller patterns Mar 6, 2024
ireneisdoomed
ireneisdoomed approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@ireneisdoomed ireneisdoomed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense, ty! See my comment

.github/labeler.yml Show resolved Hide resolved
@d0choa d0choa merged commit 8b865fe into dev Mar 7, 2024
4 checks passed
@d0choa d0choa deleted the do_labeller_start_fix branch March 7, 2024 11:39
DSuveges pushed a commit that referenced this pull request Mar 8, 2024
@d0choa @DSuveges
fix: pr labeller patterns (#523)
f6e0ad0 
* fix: pr labeler patterns

* fix: change bug for fix

* revert: as per reviewers will
@d0choa d0choa mentioned this pull request Mar 12, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ireneisdoomed ireneisdoomed ireneisdoomed approved these changes

Assignees
No one assigned
Labels
bug Something isn't working size-S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d0choa @ireneisdoomed