Remove brightness filter for map tiles in dark mode styles #5327
Conversation
|
Glad to see this change! It's a shame that @AntonKhorev saw all the feedback about the dimmed map and completely ignored it with fast tracking this change #5330 instead of removing the filter all together until #5336 is completed. |
I saw that there's a bug.
This is a fix for that bug.
That's not what necessarily will be deployed. |
|
What are you waiting to merge this? |
This PR needs to be updated, because another PR was recently merged that alters the brightness filter. |
|
Can someone please rebase and merge this? Its monday, plenty of office-going people will see the darkened map for the first time and it would help immensely to avoid the influx of bugreports and complaints on support channels. We know from the large amount of upheaval that this css rule brought that this is not the right solution, so I'm not making this up. We've only seen the volunteer's reaction so far, not the big crowds. Thanks! |
Generated by 🚫 Danger |
Maybe for discussion in #5328 to conclude? Reacting to comments there or posting new, if you have something new to say, may be a good idea. |
@matkoniecz The problem is that the map should not have been dimmed to begin with, especially without any proper discussion. This should be merged and the map should remain as default until #5328 is concluded. |
@matkoniecz Whatever the outcome of #5328 comes to it seems very unlikely the consensus will be to keep the current dimming filter as is. This dimming filter is highly controversial and should be reverted until there is consensus on how to approach dark mode for maps. Opinions elsewhere in the osm community seem pretty upset with the dark mode filter change: |
|
@gravitystorm I found another technical reason to merge this ASAP: the filter is causing a black and white grid to flicker around tiles borders while zooming on Chrome. It’s slightly noticeable on desktop but very annoying on mobile. |
Description
It's nice to finally have a dark mode on the website but reducing the brightness of the default map tiles is not ideal and negatively affects the user experience. This PR removes the filter on the map tiles to keep the default view of the map.
Sets the dark mode view to this:
from this:
I also tested the brightness at .95 which is quite bearable if the dimming is necessary.
