Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge C# & OSM task manager implementation #72

Draft
wants to merge 56 commits into
base: master
Choose a base branch
from
Draft

Merge C# & OSM task manager implementation #72

wants to merge 56 commits into from

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Apr 17, 2023

No description provided.

@stefanb stefanb marked this pull request as draft April 17, 2023 08:39
DavidKarlas and others added 29 commits August 19, 2023 09:57
@DavidKarlas
Initial version of OsmGursBuildingImport
d26f5f8
@DavidKarlas
Switch from blob to azure functions URL
05a4fdf 
Problem with using blob directly is, even though its public access it fails when JOSM passes in OAuth token for OSM...
@DavidKarlas
Switch from using Overpass to downloaded .original.osm file
c556bb8
@DavidKarlas
Switch from osmosis to osmium for generating extracts
2aed071
@DavidKarlas
Fix "addr:village" being set for Ljubljana
4ecb9a3
@DavidKarlas
Stop emitting fixme tags on casing change
d292038
@DavidKarlas
Move TaskManager .json creation logic to new file
b6c3342
@DavidKarlas
Do LinearRing->Polygon conversion sooner
8c42527
@DavidKarlas
Async main
0ffed7c
@DavidKarlas
Switch to .bz2 and fix some issues with osmium poly generation
adf1437
@DavidKarlas
Start handling existing addresses set on nodes
9cc6683
@DavidKarlas
Always load GURS-DOF025 even if area intersects with Ljubljana
4b8693c
@DavidKarlas
Fix bug where ref:gurs:sta_sid was not applied on matched buildings
f90f75c
@DavidKarlas
Added fixme for big buildings.
d41f1a0
@DavidKarlas
Match buildings by sta_sid
5d54fd4
@DavidKarlas
Don't error if no data/temp/ folder yet and don't error on first run …
bebd26b 
…with `find`
@DavidKarlas
Stop ugly workaround for VSMac
d1714dd
@DavidKarlas
Minor changes to output folder
4c75a3f
@DavidKarlas
Initial version of script that does it all
ce39d09
@DavidKarlas
Remove layer_locked=true from full.osm
e729d91 
This is so we can do selection and merge for some areas
@DavidKarlas
If Street has ID=0 it means village doesn't have streets, which means…
2d3ed4f 
… name of village and street is same

But since in such cases Overrides folder only contains data for village names, use village instead street in such cases...
@DavidKarlas
Reworked logic from being CLI tool that produces bunch of files into …
a687e8e 
…server that serves fresh data
@DavidKarlas
Fixed problem with NTS coming from MyGet and made paths absolute
cc78185
@DavidKarlas
Switch to http, to make things easier, JOSM doesn't mind
5cb55f8
@DavidKarlas
Fixed bug where .poly files were not written out fully
7a21062
@DavidKarlas
Switch to using local osmx extract
ca68924
@DavidKarlas
Use XML instead of PBF, to get file bounds for free
16cfa2e
@DavidKarlas
Add Source=GURS and comment to changeset
ce8f097
@DavidKarlas
Fix bug where old temp files were left behind and program couldn't de…
3751f81 
…cide which to use
DavidKarlas and others added 17 commits August 19, 2023 09:57
@DavidKarlas
Make poly generation more robust...
77f2ad7
@DavidKarlas
Remove all addr:place
58795cb
@DavidKarlas
Also remove hamlet
1fc3807
@DavidKarlas
Properly handle dual language situation
cb2e9c4
@DavidKarlas
Fix bug where elements that were just modified(tags changed) are not …
d2ab897 
…uploaded by JOSM

Fixed by adding "action=modified" attribute on .xml
@DavidKarlas
Whops small typo...
b89be25
@DavidKarlas
Removed fixme for big buildings
8d7548c 
Because I often missed it(uploaded before removing) and because in reality every building needs to be reviewed anyway...
@DavidKarlas
Fix relationships not having type=multipolygon
700abb5
@DavidKarlas
Switch from picking up VotingAreas each time from latest data to fixe…
028a49a 
…d GeoJson

Our TaskManager has list of tasks with geoemetries and Ids as they were in Feburary of 2022, but since VLV.shp keeps changing with time we started diverging on Geoemetries and IDs of loaded areas in JOSM vs. taks, hence use VLV.geojson from Februrary...
@DavidKarlas
Limit to just LV units, otherwise we have duplicated keys...
0d5d1eb
@DavidKarlas
OSMExpress really doesn't like some .poly files
14dcfe9 
Hopefully using GeometryFixer will make it happy...
@DavidKarlas
I guess fixer can make Multipolygon out of Polygon...
e1ece23
@DavidKarlas
Migrate from old GURS data to new format
d2fb9b9
@DavidKarlas
Switch back to old IDs(without huge 1002000 in front
4f446b3 
And add construction_date tag, useful when not sure if ortofoto is out of date or GURS data
@DavidKarlas
Switch from using GEOM column to E and N columns
093ebc0
@stefanb @DavidKarlas
Use latest 2022 orthophoto available in Ljubljana
61bae1e 
https://josm.openstreetmap.de/wiki/Maps/Slovenia#Ljubljana:Orthophoto2022WMTS
@DavidKarlas
Remove unused createBuildings.sh and getFilteredPbf.sh and revert cha…
5f8b6e5 
…nges to getSource.sh to be in sync with upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanb @DavidKarlas