Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tabKeyNavigation for all tables #1293

Closed
wants to merge 1 commit into from

Conversation

user202729
Copy link
Member

@user202729 user202729 commented Apr 24, 2021

Summary of changes

Title.

Note: pull request only opened for running GitHub CI. It isn't clear whether this is the best option.

An alternative behavior would be

  • Tab will jump to the next row, or the next component if the current row is the last.
  • Shift+tab will jump to the previous row, or the previous component if the current row is the first.

However this requires more than toggling a simple flag.

Note: even with this, shift+tab cannot cycle through all components in the main interface -- might need more investigation.

Pull Request Checklist

  • Changes have tests (GUI only, cannot test)
  • News fragment added in news.d. See documentation for details

@user202729 user202729 marked this pull request as ready for review April 24, 2021 06:39
@nvdaes
Copy link
Contributor

nvdaes commented Apr 24, 2021

I've tested this locally running from source and I'd like this change to be included in Plover.
I'd also like that tables has a name, to be read when focus moves to them.
Thanks

@benoit-pierre benoit-pierre mentioned this pull request May 2, 2021
2 tasks
@benoit-pierre
Copy link
Member

benoit-pierre commented May 2, 2021

Closing in favor of #1308, which includes this PR commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants