Updates SQLMesh to the latest version #2679
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ravenac95
temporarily deployed
to
external-prs-app
GitHub Actions
Inactive
ravenac95
commented
Dec 21, 2024
| @@ -59,7 +59,7 @@ sqlalchemy = "^2.0.25" | |||
| textual = "^0.52.1" | |||
| redis = "^5.0.7" | |||
| githubkit = "^0.11.6" | |||
| sqlmesh = { extras = ["trino"], version = "^0.129.0" } | |||
| sqlmesh = "^0.141.1" | |||
There was a problem hiding this comment.
Will need to add the trino extras here
ravenac95
commented
Dec 21, 2024
| @@ -21,6 +21,9 @@ | |||
| connection=DuckDBConnectionConfig( | |||
| database=os.environ.get("SQLMESH_DUCKDB_LOCAL_PATH") | |||
| ), | |||
| test_connection=DuckDBConnectionConfig( | |||
There was a problem hiding this comment.
Remove this local testing thing!
![oso-prs[bot]](https://avatars.githubusercontent.com/in/856587?s=60&v=4){kind=small}
|
Test deployment unnecessary, no dbt files have been changed. |
ravenac95
temporarily deployed
to
external-prs-app
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to run some manual tests to ensure that this still functions properly. I also tried to simplify a few things. This is so we can get all of the dagster_sqlmesh things upgraded as well.
This also significantly simplifies the model factory generation. Uses something the sqlmesh folks eluded to in our convo with reorganizing how we did imports to get that to work properly (that's because it wasn't working with the latest updates). This should make this all much less brittle.