Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More MCS Bugs #2668

Merged
merged 2 commits into from
Dec 18, 2024
Merged

More MCS Bugs #2668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64c84a1
Ensure the import isn't actually made into trino with failed data
ravenac95 Dec 18, 2024
9ccb823
Additional fixes for error handling
ravenac95 Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions warehouse/metrics_tools/compute/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,7 @@ async def _handle_query_job_submit_request(
exported_dependent_tables_map = await self.resolve_dependent_tables(input)
except Exception as e:
self.logger.error(f"job[{job_id}] failed to export dependencies: {e}")
await self._notify_job_failed(job_id, False, e)
return
raise e
self.logger.debug(f"job[{job_id}] dependencies exported")

tasks = await self._batch_query_to_scheduler(
Expand All @@ -163,18 +162,22 @@ async def _handle_query_job_submit_request(
f"job[{job_id}] task failed with uncaught exception: {e}"
)
exceptions.append(e)
# Report failure early for any listening clients. The server
# will collect all errors for any internal reporting needed
await self._notify_job_failed(job_id, True, e)

# If there are any exceptions then we report those as failed and short
# circuit this method
if len(exceptions) > 0:
raise JobTasksFailed(job_id, len(exceptions), exceptions)

# Import the final result into the database
self.logger.info("job[{job_id}]: importing final result into the database")
await self.import_adapter.import_reference(calculation_export, final_export)

self.logger.debug(f"job[{job_id}]: notifying job completed")
await self._notify_job_completed(job_id)

if len(exceptions) > 0:
raise JobTasksFailed(job_id, len(exceptions), exceptions)

async def _batch_query_to_scheduler(
self,
job_id: str,
Expand Down
Loading