feat: llm led data dictionary generation for dbt models #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
evanameyer1
temporarily deployed
to
external-prs-app
GitHub Actions
Inactive
ryscheng
reviewed
Nov 23, 2024
There was a problem hiding this comment.
lgtm. feel free to merge.
as discussed in our call, we'll just treat this as an isolated experimental script for now. There are a number of steps we'd need to take before it will work in a reproducible dev / prod setting (future work):
- Enumerating dependencies using poetry
- Either removing service dependencies (MongoDB) or adding the service in a way that prod can access (i.e. kubernetes)
- Fixing the Google auth to use our production secrets manager (or env files if running locally)
- Turning this into something that folks can run regularly. I'd probably suggest something simple to start and just turn it into a CLI tool that developers can run periodically i.e. a poetry script.
- Adapting it for our new sqlmesh setup (TBD what that looks like)
Anyway, I'll merge for now, we can always do this other stuff later
ryscheng
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llm led data dictionary generation for dbt models