-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update contract event types for L2 source data #1405
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
transactions.receipt_gas_used as l2_gas_used | ||
transactions.receipt_gas_used as l2_gas_used, | ||
--transactions.receipt_l1_gas_used as l1_gas_used, | ||
block_number, -- #TODO: get from the receipt data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ravenac95 not sure how to grab the block_number
field from the source model since it's not GoldSky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we'd have to join the blocks at the int_optimism_transactions
model to get that data.
Test deployment for PR #1405 successfully deployed to |
`from_namespace`, | ||
`from_type`, | ||
`from_source_id`, | ||
--`event_source_id`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ravenac95 not sure how to handle event_source_id
values across all these CTEs (here is one example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya... good question ... have we intended the event_source_id
to be unique across int_events
because as it stands right now event_source_id
i feel like would always potentially have dupes even for github events but perhaps we solved that in a different way?
No description provided.