Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update contract event types for L2 source data #1405

Merged
merged 9 commits into from
May 14, 2024

Conversation

ccerv1
Copy link
Member

@ccerv1 ccerv1 commented May 13, 2024

No description provided.

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kariba-network ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 4:05am
oso-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 4:05am
oso-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 4:05am

@ccerv1 ccerv1 temporarily deployed to external-prs-app May 13, 2024 18:26 — with GitHub Actions Inactive
@ccerv1 ccerv1 requested a review from ravenac95 May 13, 2024 18:27
@vercel vercel bot temporarily deployed to Preview – oso-docs May 13, 2024 18:27 Inactive
@vercel vercel bot temporarily deployed to Preview – oso-frontend May 13, 2024 18:28 Inactive
transactions.receipt_gas_used as l2_gas_used
transactions.receipt_gas_used as l2_gas_used,
--transactions.receipt_l1_gas_used as l1_gas_used,
block_number, -- #TODO: get from the receipt data
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravenac95 not sure how to grab the block_number field from the source model since it's not GoldSky

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we'd have to join the blocks at the int_optimism_transactions model to get that data.

@oso-prs
Copy link

oso-prs bot commented May 13, 2024

Test deployment for PR #1405 successfully deployed to oso-pull-requests.pr_1405.

`from_namespace`,
`from_type`,
`from_source_id`,
--`event_source_id`,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravenac95 not sure how to handle event_source_id values across all these CTEs (here is one example)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya... good question ... have we intended the event_source_id to be unique across int_events because as it stands right now event_source_id i feel like would always potentially have dupes even for github events but perhaps we solved that in a different way?

@ccerv1 ccerv1 temporarily deployed to external-prs-app May 14, 2024 03:00 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – oso-docs May 14, 2024 03:00 Inactive
@vercel vercel bot temporarily deployed to Preview – oso-frontend May 14, 2024 03:02 Inactive
@vercel vercel bot temporarily deployed to Preview – oso-docs May 14, 2024 03:22 Inactive
@vercel vercel bot temporarily deployed to Preview – oso-frontend May 14, 2024 03:24 Inactive
@ccerv1 ccerv1 temporarily deployed to external-prs-app May 14, 2024 04:00 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – oso-frontend May 14, 2024 04:02 Inactive
@vercel vercel bot temporarily deployed to Preview – oso-docs May 14, 2024 04:05 Inactive
@ccerv1 ccerv1 added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 53aee6f May 14, 2024
7 checks passed
@ccerv1 ccerv1 deleted the dbt/update-contract-event-types branch May 14, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create daily contract_invocation event types instead of bringing all events to int level
2 participants