Skip to content

Commit

Permalink
Attempts to set the correct readonly values (#1607)
Browse files Browse the repository at this point in the history
  • Loading branch information
ravenac95 authored Jun 9, 2024
1 parent 742d360 commit 4e94b80
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ops/helm-charts/oso-dagster/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: oso-dagster
description: Extension of the dagster template

type: application
version: 0.1.10
version: 0.1.11
appVersion: "1.0.0"
dependencies:
- name: dagster
Expand Down
2 changes: 1 addition & 1 deletion ops/helm-charts/oso-dagster/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,5 @@ postgres_db:
{{- $name := default "webserver" .Values.dagsterWebserver.nameOverride -}}
{{- $fullname := include "dagster.fullname" . -}}
{{- printf "%s-%s" $fullname $name | trunc 63 | trimSuffix "-" -}}
{{- if .webserverReadOnly -}} --read-only {{- end -}}
{{- if .webserverReadOnly -}} -read-only {{- end -}}
{{- end -}}
1 change: 0 additions & 1 deletion ops/helm-charts/oso-dagster/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ dagster:
postgresql:
enabled: false
postgresqlPassword: "gcp:secretmanager:dagster-db-password/versions/1"
enableReadOnly: true

configMap:
name: "dagster-extra-env-config-map"
Expand Down
2 changes: 2 additions & 0 deletions ops/k8s-apps/base/dagster/dagster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ spec:
pythonLogs:
pythonLogLevel: "INFO"
nameOverride: "dagster"
dagsterWebserver:
enableReadOnly: true
ingress:
enabled: true
ingressClassName: ingress-internal-cloudflare
Expand Down

0 comments on commit 4e94b80

Please sign in to comment.