Skip to content

Commit

Permalink
Always materialize ossd projects and collections (#1896)
Browse files Browse the repository at this point in the history
* Always materialize ossd projects and collections

Closes: #1878

* change log to warning
  • Loading branch information
ravenac95 authored Jul 31, 2024
1 parent 14e857a commit 18ae415
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions warehouse/oso_dagster/assets/ossd.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,13 @@ def projects_and_collections(
}
)
# The previous sha for this asset and the current sha match. No
# need to update anything
# need to update anything.

# FIXME in the future we should skip already materialized shas
# if possible. For now we cannot, see:
# https://github.com/dagster-io/dagster/discussions/19403
if repo_meta_dict.get("sha", "") == data.meta.sha:
context.log.info(f"no changes for {output}")
continue
context.log.warn(f"no changes for {output}. Materializing anyway")
df = oss_directory_to_dataframe(output, data)

yield Output(
Expand Down

0 comments on commit 18ae415

Please sign in to comment.