This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
README.md contributing fix #716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes openshift#715 Signed-off-by: João Gonçalves <[email protected]>
|
LGTM. @Miciah could you merge this please? |
|
Looks like |
|
@Miciah makes sense to me. At some point we stopped writing Cucumber tests in favour of RSpec, but there are still a significant amount of them (which are important), and I don't see them all being converted. |
|
bump. Please either merge or close (and fix appropriately) |
|
Closing this ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: João Gonçalves [email protected]